Repository navigation
sync game data automatically - #2
Merged
Merged
Conversation
the static data was a one-off snapshot from august and the scripts that built it weren't in the repo, so it never updated. this adds a sync that rebuilds it every 6 hours from NotEnoughUpdates-REPO, SkyShards-Parser and the hypixel api. broken data stops the sync, suspicious changes wait for a review, and everything else goes live. the site now shows when data last synced, and warns if syncing stops or the bazaar lists shards it doesn't know about. fixes found along the way: - every craft was labelled common, which also emptied the rarity filters - slayer levels used the zombie xp table for every slayer - essence recipes with an unpriced material would have counted it as free - esc() didn't escape quotes - bazaar tax is now a setting, since it depends on the community shop upgrade
first run of scripts/sync-data.mjs. - fusions: 131,748, replacing a list that counted A+B and B+A separately - new shards: Chocobun, Packrat, Folf, Flora - fuse amount: Sepialot and Goldolot take 2, not 5 - crafts: real rarities, unlock requirements, and recipes the old build missed - essence shops now come from NotEnoughUpdates-REPO
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what this does
the site's recipes and fusions were a one-off snapshot from august, and the scripts that built them weren't in the repo, so they never updated. this adds a github action that rebuilds them every 6 hours and publishes the result to
main, which deploys on vercel.safety checks
data-sync-reviewbranch for you to look at.third-party text now reaches the page without review, and that page's localStorage holds api keys, so the sync rejects html characters and enforces strict formats on anything that goes into an html attribute.
esc()also escapes quotes now.wrong info this fixes
compared on the same frozen prices:
count, recipes stored in.recipes[], and ids likeINK_SACK-3.Enchanting X) are shown on the card but don't hide the craft.also: bazaar tax is now a number box, defaulting to the old 1.125%. i could only find one guide for the rates (1.25% base, 1.125% with the free upgrade), so please check that's right. "verified recipe ingredients" now just says "recipe ingredients", since we can't verify them.
testing
publish-sync.shagainst a throwaway git remote with a fakegh: publishing, nothing to publish,mainmoving mid-sync, review, and the issue fallback. also not in this pr.not tested on github: schedules only run from the default branch, so the publish and review steps can't run until this is merged. this pr only runs the tests and a dry run on github. the review logic was tested locally, as above.
after merging
still not guaranteed
hypixel doesn't publish recipes or fusion rules, so these depend on community projects. fusion updates rely on the parser's maintainer running it, and the site can spot new shards but not changed fusion rules. the parser's nov 3 fix itself says "not 100% accurate due to game bug". anvil limits, order caps and 11 slayer unlocks are still maintained by hand. the readme covers this.
items/,collections.json,profit.txtandshard_fusion_profit.pyare no longer used by anything, anditems/still gets deployed. i left them out of this pr to keep it reviewable, but they can be deleted.🤖 Generated with Claude Code